HTML API: Preserve PRE/LISTING newline skipping after seek#58
Open
sirreal wants to merge 1 commit into
Open
Conversation
sirreal
changed the title
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
WP_HTML_Tag_Processor::seek()when returning to a bookmark set on a text node that suppresses the first LF after<pre>or<listing>.Before this change, the first scan of
<pre>\n \n\n><pre>returned" \n\n>", but seeking back to a bookmark on that same text token returned"\n \n\n>". The bookmark stored the token span, but not the parser state that says the leading newline should be skipped.This change:
seek()before reparsing the bookmarked token;skip_newline_ataligned when pending lexical updates shift token offsets;Testing
WP_TESTS_SKIP_INSTALL=1 ./vendor/bin/phpunit --group html-api,html-api-html5lib-tests./vendor/bin/phpcs --standard=phpcs.xml.dist src/wp-includes/html-api/class-wp-html-tag-processor.php tests/phpunit/tests/html-api/wpHtmlTagProcessor-bookmark.php tests/phpunit/tests/html-api/wpHtmlTagProcessorModifiableText.php tests/phpunit/tests/html-api/wpHtmlProcessorModifiableText.phpphp -lon changed PHP filesgit diff --checkTrac ticket: TBD
Use of AI Tools
AI assistance: Yes
Tool(s): Codex
Model(s): GPT-5
Used for: diagnosing the seek replay bug, implementing and iterating on tests, running adversarial review passes, and drafting this PR description.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.